OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_22_2-16-g787fbc5

Gerrit Code Review
Fri, 23 Feb 2018 13:48:29 -0500

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 787fbc5bfa4c06225055bd4142a4f99be344ba8e
Author: Andrew Deason <>
Date:   Thu Feb 15 16:41:33 2018 -0600

    rxdebug: NUL-terminate version before printing
    Currently, 'rxdebug -version' never initializes the buffer we read the
    version string into. Usually this is not noticeable, since all OpenAFS
    binaries tend to pad the Rx version response packet with NULs, so we
    get back several NULs to terminate the string. However, this is not
    guaranteed, and if we do not get back a NUL-terminated string, we can
    easily read beyond the end of the buffer.
    To avoid this, initialize the 'version' buffer with NULs before we do
    anything, and set the last byte to NUL, in case we exactly filled the
    Reviewed-by: Benjamin Kaduk <>
    Tested-by: Andrew Deason <>
    (cherry picked from commit a66629eac4dda4eea37b4f06e0850641cb2a7387)
    Tested-by: BuildBot <>
    Reviewed-by: Benjamin Kaduk <>
    (cherry picked from commit 55fbc8ee055958b309011eeb62d7166ff0415905)
    Change-Id: I3a35be6bba422261f4a19e4db597233f4e7ed6a3
    Reviewed-by: Andrew Deason <>
    Tested-by: BuildBot <>
    Reviewed-by: Stephan Wiesand <>

 src/rxdebug/rxdebug.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

OpenAFS Master Repository