OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_1pre1-1-g0c85511

Gerrit Code Review
Sun, 1 Jul 2018 13:37:26 -0400

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 0c8551135a6be6e81d79eeb117be43a0b783d7be
Author: Mark Vitale <>
Date:   Sat Jun 30 17:35:09 2018 -0400

    rxevent: prevent negative rx_connection refCount
    rxi_ChallengeEvent is called directly from rxi_ChallengeOn to start the
    first challenge; subsequent calls to rxi_ChallengeEvent are from the
    event handler.  When called as an event, we must putConnection the
    reference held by the event.  But when called directly for the first
    time, the event has not been scheduled yet and so has not taken a
    reference on the connection.  For this case, we must not putConnection
    or the rx_connection refCount will go negative.
    One reported symptom of this bug is a fileserver crash with:
      'Assertion failed! file rx.c, line 1327.'
    Introduced by commit 304d758983b499dc568d6ca57b6e92df24b69de8
    ('Standardize rx_event usage').
    Reviewed-by: Benjamin Kaduk <>
    Tested-by: BuildBot <>
    (cherry picked from commit b1ad473be01162fe9b3835544a835c4dcf0fcb35)
    Change-Id: Ice5856627f4f77b5ede3a84fef4b6f2915f5477d
    Tested-by: BuildBot <>
    Reviewed-by: Mark Vitale <>
    Reviewed-by: Benjamin Kaduk <>

 src/rx/rx.c |   22 +++++++++++++---------
 1 files changed, 13 insertions(+), 9 deletions(-)

OpenAFS Master Repository