OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_0-16-g92de726
Gerrit Code Review
gerrit@openafs.org
Sat, 2 Jun 2018 18:21:11 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit 92de7260ee45200b6832cb7f727a582fc37c3699
Author: Andrew Deason <adeason@sinenomine.net>
Date: Mon Apr 30 17:58:43 2018 -0500
afs: WriteThroughDSlots: Avoid write error panic
Currently, afs_WriteThroughDSlots panics if our call to
afs_WriteDCache fails. Since afs_WriteThroughDSlots is called every
minute by a background daemon, this means that if our cache fs becomes
inaccessible (by being forced read-only, or for any other reason), we
are virtually guaranteed to panic relatively quickly.
To try to avoid this at least for some cases, change
afs_WriteThroughDSlots to return an error to our caller when we
encounter such an error. For our background task, we can just ignore
the error and retry the writes on a future iteration. During shutdown,
we still panic if we encounter an error, to try to avoid silently
allowing a corrupt cache to be used on subsequent boots.
Reviewed-on: https://gerrit.openafs.org/13047
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit 46d5695a383b2b993fdd598b770f4e3c0e1a41f3)
Change-Id: Iccbec550c00ac725c0033b075ac3cd0b4e1c78c2
Reviewed-on: https://gerrit.openafs.org/13073
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/afs/afs_daemons.c | 2 +-
src/afs/afs_dcache.c | 20 ++++++++++++++++----
src/afs/afs_init.c | 2 +-
src/afs/afs_prototypes.h | 2 +-
4 files changed, 19 insertions(+), 7 deletions(-)
--
OpenAFS Master Repository