OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_0-24-gdba69c2

Gerrit Code Review gerrit@openafs.org
Sat, 2 Jun 2018 19:06:39 -0400


The following commit has been merged in the openafs-stable-1_8_x branch:
commit dba69c2a190103d1941ca6232d9a466f259a206c
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Feb 19 13:57:16 2018 -0500

    butc: fix format overflow warning
    
    Recent versions of gcc generate an overflow warning in the butc DUMPNAME macro
    when copying values into the finishedMsg1 buffer. Increase the size of the
    destination buffer to avoid a possible buffer overflow.
    
        dump.c:88:24: error: ‘%s’ directive writing up to 63 bytes into
        a region of size 50 [-Werror=format-overflow=]
              sprintf(dumpname, "%s (DumpId %u)", name, dbDumpId);
                                ^
        dump.c:1294:5: note: in expansion of macro ‘DUMPNAME’
             DUMPNAME(finishedMsg1, nodePtr->dumpSetName, dparams.databaseDumpId);
             ^~~~~~~~
        dump.c:88:6: note: ‘sprintf’ output between 12 and 84 bytes into
        a destination of size 50
              sprintf(dumpname, "%s (DumpId %u)", name, dbDumpId);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        dump.c:1294:5: note: in expansion of macro ‘DUMPNAME’
             DUMPNAME(finishedMsg1, nodePtr->dumpSetName, dparams.databaseDumpId);
             ^~~~~~~~
    
    Reviewed-on: https://gerrit.openafs.org/12916
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    (cherry picked from commit cec45d59440f55316097cfd6652d2ea26cd55233)
    
    Change-Id: I9f3b284d4a32b868091986964af128ed9b3557fd
    Reviewed-on: https://gerrit.openafs.org/13097
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/butc/dump.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository