OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_0-72-g41285fc

Gerrit Code Review
Fri, 15 Jun 2018 08:40:52 -0400

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 41285fc801cfa91e099e042ab2bc85599fac63fb
Author: Michael Meffie <>
Date:   Fri Apr 27 23:08:34 2018 -0400

    util: check for trailing characters in partition names
    The function which maps partition names to partition ids currently
    ignores trailing characters in the partition names. For example, the
    partition name "/vicepbogus" is currently considered a valid partition
    name ("/vicepbogus" maps to "bo" which is id 66). Although this is not a
    regression, it is problematic for several reasons.
    Firstly, this can lead to duplicate partition ids on the server, for
    example "/vicepbad" and "/vicepbar" both map to the same partition id
    ("ba" is id 52).
    Second, partitions are internally tracked by numeric id. The partition
    names are generated from numeric ids when reporting partition names.
    This means the trailing characters are lost when reporting the partition
    names. For example, vos reports the attached partition "/vicepbad" as
    Third, it could be possible (but perhaps unlikely) in the future to
    extend the range of partition ids, so the trailing characters could
    become significant at that time.
    Finally, it could be confusing to admins that such partition names are
    attached by the fileserver. For example, "/vicepaa-backup" is attached
    and is used by the fileserver as partition id 26.
    This change adds a check for trailing characters in partition names in
    the volutil_GetPartitionID function, so it is more strict in what it
    accepts as a valid partition name.  That function will now return -1
    (illegal partition name) when trailing characters are found in
    partition names.
    Reviewed-by: Benjamin Kaduk <>
    Tested-by: BuildBot <>
    Reviewed-by: Andrew Deason <>
    (cherry picked from commit 850c7c50dccbdebb8e0a44da4fc7840760d9e02d)
    Change-Id: I1244630f3b31408f9f723b97956dca6987dd9747
    Tested-by: BuildBot <>
    Reviewed-by: Michael Meffie <>
    Reviewed-by: Joe Gorse <>
    Reviewed-by: Marcio Brito Barbosa <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Mark Vitale <>
    Reviewed-by: Benjamin Kaduk <>

 src/util/volparse.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

OpenAFS Master Repository