OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-260-gf0bab78
Gerrit Code Review
gerrit@openafs.org
Fri, 5 Oct 2018 10:06:30 -0400
The following commit has been merged in the master branch:
commit f0bab78cbe4f59609fa18647a480cc6989948786
Author: Michael Meffie <mmeffie@sinenomine.net>
Date: Mon Oct 1 11:38:37 2018 -0400
ubik: do not reuse the offset variable for the sync site address
The ubik SendFile function performs a sanity check of the host address
before proceeding with the file transfer. Currently this check reuses
the file offset local variable to hold the value of the sync site
address, a 32-bit IPv4 address. Not only is this confusing, but also
causes a signed/unsigned type mismatch when comparing host addresses.
Instead of being so stingy with local variables, declare a new local
variable of the correct type to hold the value of the sync site address.
This separation is also a prerequisite for supporting larger address
types in the future.
Change-Id: I116fe210f418e6914afeff37c44d30bf795e2413
Reviewed-on: https://gerrit.openafs.org/13351
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/ubik/remote.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository