OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-363-g3d22ce3
Gerrit Code Review
gerrit@openafs.org
Fri, 19 Apr 2019 10:37:56 -0400
The following commit has been merged in the master branch:
commit 3d22ce36dcb86df564d4d91ff0e174792b30d68f
Author: Pat Riehecky <riehecky@fnal.gov>
Date: Wed Jun 6 10:01:02 2018 -0500
afsmonitor: avoid double free on exit
The afsmonitor may leak memory and do a double free on shutdown when it
was started with a non-zero -buffers parameter value. The deallocation
of the cm results circular buffer incorrectly frees the base of the
array of results instead of each result. The fs buffer clean up got
this right.
This fixes the clang scan-build warning:
afsmonitor.c:461:7: warning: Attempt to free released memory
free(tmp_cmlist);
^~~~~~~~~~~~~~~~
[mmeffie: update code and commit message]
Change-Id: Ifd4ea5b9b865f04e5cf88560dd8a9dfdbe7e32cb
Reviewed-on: https://gerrit.openafs.org/13161
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/afsmonitor/afsmonitor.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
OpenAFS Master Repository