OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-412-gbf24b30
Gerrit Code Review
Fri, 2 Aug 2019 13:29:51 -0400
The following commit has been merged in the master branch:
Author: Cheyenne Wills <email@example.com>
Date: Fri Aug 2 10:31:13 2019 -0600
restorevol: replace snprintf with asprintf
GCC is generating format-truncations warnings. With newer levels of gcc
(e.g. gcc8) and --checking-enabled these warnings result in errors and
failed builds. In addition clang8 static analysis tools are reporting
Replace snprintf with asprintf and eliminate some of the large work
buffers that are being placed on the stack. In order to correct some of
the format-truncation errors the size of the buffers grew significantly
(e.g. gcc is reporting the need to resize some of the buffers from 256
bytes to 4K in order to eliminate the warnings).
Ensure allocated work buffers are freed before function return.
Obtained a clean build with gcc9/clang8 with --enable-checking and a
clean scan-build report with clang8.
Reviewed-by: Benjamin Kaduk <firstname.lastname@example.org>
Tested-by: BuildBot <email@example.com>
src/volser/restorevol.c | 316 ++++++++++++++++++++++++++++++++++++-----------
1 files changed, 241 insertions(+), 75 deletions(-)
OpenAFS Master Repository