OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-404-g98ca332

Gerrit Code Review gerrit@openafs.org
Fri, 26 Jul 2019 09:07:43 -0400


The following commit has been merged in the master branch:
commit 98ca332c4a5ac9e5687fb4fe21b350134bc74d1b
Author: Cheyenne Wills <cwills@sinenomine.net>
Date:   Mon Jul 15 08:38:24 2019 -0600

    rxkad: v5der.c format truncation warnings
    
    GCC 7 is producing new warnings due to better compile time analysis.
    With --enable-checking v5der.c is failing with 2 errors due to possible
    format-truncation in some snprintf calls.  The format strings are being
    used to format a date and time values from a tm structure.
    
    The actual warnings/errors are being triggered from arithmetic being
    performed on the year and month members of the structure. The resulting
    values should not exceed the format lengths, but the compilers are still
    flagging the statements.
    
    v5der.c is part of the heimdal package that is pulled into the openafs
    source tree.  v5der.c is not compiled directly but is #included in
    ticket5.c
    
    Update ticket5.c to change the severity of the format-truncation
    diagnostic to a warning if using GCC 7 (or higher).
    
    Note: since v5der.c is pulled from an external source (heimdal), any
    changes to update v5der.c directly would need to be performed upstream.
    
    Change-Id: Icda0d86444f505604abe9fa1cc2450d7538be7ef
    Reviewed-on: https://gerrit.openafs.org/13661
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 CODING              |    6 +++++-
 src/rxkad/ticket5.c |    9 +++++++++
 2 files changed, 14 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository