OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_3-13-g74054de

Gerrit Code Review gerrit@openafs.org
Mon, 10 Jun 2019 07:38:01 -0400


The following commit has been merged in the openafs-stable-1_8_x branch:
commit 74054de1bc30cee1bdc9d0c350230231663bcd85
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Thu Sep 6 13:42:11 2018 -0500

    Run ctfconvert/ctfmerge for all objects
    
    Commit 88cb536f (autoconf: detect ctf-tools and add ctf to libafs)
    introduced running ctfconvert and ctfmerge for libafs on Solaris, but
    didn't add any CTF data for userspace code. This commit causes the
    same commands to be run for every binary that we build (if the ctf
    tools are available).
    
    To accomplish this, also refactor how we run ctfconvert and ctfmerge.
    The approach in commit 88cb536f would require us to modify the
    makefile rule for every executable to run RUN_CTFCONVERT and
    RUN_CTFMERGE, which is somewhat impractical. So instead in this
    commit, we modify all of our *_CCRULE and *_LDRULE variables to wrap
    the compiler invocation with the new CC_WRAPPER script. This means our
    *RULE variables change from something like this:
    
        FOO_CCRULE = $(RUN_CC) $(CC) $(XXX_FLAGS) -o $@
    
    to something like this:
    
        FOO_CCRULE = $(RUN_CC) $(CC_WRAPPER) $(CC) $(XXX_FLAGS) -o $@
    
    CC_WRAPPER expands to the script src/config/cc-wrapper, which just
    runs ctfconvert or ctfmerge on the relevant files after the
    compiler/linker runs. If the CTF tools are not configured, CC_WRAPPER
    expands to nothing, to limit our impact on other platforms.
    
    This commit was developed in collaboration with
    mbarbosa@sinenomine.net.
    
    Reviewed-on: https://gerrit.openafs.org/13308
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    (cherry picked from commit c1d39153da00d5525b2f7874b2d214a7f1b1bb86)
    
    Change-Id: Ic357293a946f0759aa032f7c93b4b56e74e9209a
    Reviewed-on: https://gerrit.openafs.org/13487
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

 configure.ac                        |    4 +-
 src/cf/ctf-tools.m4                 |    8 +++
 src/config/.gitignore               |    1 +
 src/config/Makefile.config.in       |   67 ++++++---------------
 src/config/Makefile.pthread.in      |    4 +-
 src/config/cc-wrapper.in            |  112 +++++++++++++++++++++++++++++++++++
 src/libafs/Makefile.common.in       |    6 +-
 src/libafs/MakefileProto.SOLARIS.in |   12 ++--
 src/tsalvaged/Makefile.in           |    2 +-
 9 files changed, 154 insertions(+), 62 deletions(-)

-- 
OpenAFS Master Repository