OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_3-15-g390bb18

[Gerrit Code Review]

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 390bb188b956d43f569ca10909d0a968355cddb9
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Fri Sep 28 17:12:40 2018 -0500

    afs: Remove afs_xosi
    
    Since OpenAFS 1.0, all platforms in libafs have a lock called
    afs_xosi, which is acquired and released around calls like VOP_GETATTR
    on cache files. However, this lock doesn't appear to protect anything;
    on all platforms, the code that runs while the lock is held uses only
    calls VOP_GETATTR and accesses local variables (aside from
    afs_osi_cred, which we use similarly in many other places). The
    purpose of the lock has never been documented, and is not mentioned at
    all in the afs_rwlocks text file.
    
    The comment by the afs_xosi lock declaration suggests that the lock
    was originally introduced to protect access to 'tvattr', which perhaps
    was a global variable in the past. All uses of 'tvattr' are local now,
    though, so protecting access to it doesn't make any sense.
    
    So, remove afs_xosi, to remove the unnecessary serialization of
    VOP_GETATTR calls.
    
    Reviewed-on: https://gerrit.openafs.org/13350
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    (cherry picked from commit d75bc6370f625479a67c7c0a50cce23c4d4a4ce5)
    
    Change-Id: I33dc7935872cf071c4221d46cbb458e1f77185a2
    Reviewed-on: https://gerrit.openafs.org/13529
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

 src/afs/AIX/osi_file.c           |    5 -----
 src/afs/AIX/osi_prototypes.h     |    3 ---
 src/afs/DARWIN/osi_file.c        |    5 -----
 src/afs/DARWIN/osi_prototypes.h  |    3 ---
 src/afs/DFBSD/osi_prototypes.h   |    5 -----
 src/afs/FBSD/osi_file.c          |    5 -----
 src/afs/FBSD/osi_prototypes.h    |    3 ---
 src/afs/HPUX/osi_file.c          |    5 -----
 src/afs/HPUX/osi_prototypes.h    |    3 ---
 src/afs/IRIX/osi_file.c          |    5 -----
 src/afs/IRIX/osi_prototypes.h    |    3 ---
 src/afs/IRIX/osi_vnodeops.c      |    8 --------
 src/afs/LINUX/osi_file.c         |    5 -----
 src/afs/LINUX/osi_module.c       |    1 -
 src/afs/LINUX/osi_prototypes.h   |    1 -
 src/afs/NBSD/osi_file.c          |    5 -----
 src/afs/NBSD/osi_prototypes.h    |    3 ---
 src/afs/OBSD/osi_file.c          |    5 -----
 src/afs/OBSD/osi_prototypes.h    |    3 ---
 src/afs/SOLARIS/osi_file.c       |   11 -----------
 src/afs/SOLARIS/osi_prototypes.h |    3 ---
 src/afs/afs_callback.c           |    4 ----
 22 files changed, 0 insertions(+), 94 deletions(-)

-- 
OpenAFS Master Repository