OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-382-g34fd532

Gerrit Code Review
Fri, 28 Jun 2019 10:39:16 -0400

The following commit has been merged in the master branch:
commit 34fd532e35b6f373304effaa16c9c65062b12cd9
Author: Andrew Deason <>
Date:   Wed Aug 1 18:38:51 2018 -0500

    DARWIN: Use tb->code_raw for BOP_MOVE
    Currently, BOP_MOVE communicates its error code to the requestor via
    the 'retval' field in struct afs_uspc_param, and we assume ptr_parm[0]
    of the given brequest is for a struct afs_uspc_param. But this is
    unnecessary, since struct brequest already has fields for error codes;
    namely, code_raw and code_checkcode.
    To avoid afs_BackgroundDaemon needing to interpret ptr_parm[0] in this
    way (and assuming the type of the pointer's target), change BOP_MOVE
    to just use the code_raw field for error codes, instead of
    interpreting ptr_parm[0]. This makes it easier to add more AFS_NEW_BKG
    background operations that do not pass a struct afs_uspc_param in the
    brequest parameters.
    Change-Id: I90a564468862142777159fbb78234744840b59fb
    Reviewed-by: Mark Vitale <>
    Tested-by: BuildBot <>
    Reviewed-by: Benjamin Kaduk <>

 src/afs/DARWIN/osi_vnodeops.c |    2 +-
 src/afs/afs_daemons.c         |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

OpenAFS Master Repository