OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_23-84-g8da38fa
Gerrit Code Review
Sat, 2 Mar 2019 14:05:21 -0500
The following commit has been merged in the openafs-stable-1_6_x branch:
Author: Mark Vitale <firstname.lastname@example.org>
Date: Mon Dec 3 15:33:29 2018 -0800
afs: prevent -settime null pointer dereference
If -settime is enabled and afs_setTimeHost is non-NULL, CkSrv_SetTime
will loop over the conns array to find a matching connection for the
afs_setTimeHost. If no match is found, this loop exits with index 'i'
out of bounds for the conns array. We then call
CkSrv_MarkUpDown(&conns[i],..), leading to a null pointer dereference.
Add an additional condition so we only call CkSrv_MarkUpDown() if a
matching conn was found.
Introduced by commit 1219b7617ecfe1d9eb0d7ec22f8e2e714732c51d.
This is a 1.6.x-specific fix, since -settime support has been removed
from 1.8.x and master. Despite this fix, afsd -settime remains
deprecated in OpenAFS 1.6.x.
Reviewed-by: Michael Meffie <email@example.com>
Reviewed-by: Marcio Brito Barbosa <firstname.lastname@example.org>
Tested-by: BuildBot <email@example.com>
Reviewed-by: Stephan Wiesand <firstname.lastname@example.org>
src/afs/afs_server.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
OpenAFS Master Repository