OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_23-86-gfe6fb38
Gerrit Code Review
Sat, 2 Mar 2019 14:13:12 -0500
The following commit has been merged in the openafs-stable-1_6_x branch:
Author: Mark Vitale <firstname.lastname@example.org>
Date: Fri Nov 30 15:13:24 2018 -0800
Linux 4.20: disable -settime support
In Linux v4.20, do_settimeofday() has been removed in favor of
This commit is for 1.6.x only. On master and 1.8.x, -settime support
has been removed from OpenAFS, but on 1.6.x some sites may still be
specifying -settime even though it is deprecated and known to be broken.
Therefore, for 1.6.x we can't simply remove afs_osi_SetTime. It's also
a waste of time to convert it to use do_settimeofday64() because the
-settime feature is deprecated.
Instead, add an autoconf test to detect the absence of
do_settimeofday(). When do_settimeofday() is missing and -settime has
been specified, log a warning message whenever OpenAFS attempts to
adjust the system time:
'afs attempted to set clock; use "afsd -nosettime"'
do_settimeofday() was introduced sometime during v2.4.x and thus has
always been present in all Linux versions covered by OpenAFS conditional
AFS_LINUX26_ENV (until now).
We don't need to do anything with the LINUX24 version of
afs_osi_SetTime() since do_settimeofday() will never disappear on those
old Linux versions.
Tested-by: BuildBot <email@example.com>
Reviewed-by: Cheyenne Wills <firstname.lastname@example.org>
Reviewed-by: Marcio Brito Barbosa <email@example.com>
Reviewed-by: Stephan Wiesand <firstname.lastname@example.org>
src/afs/LINUX/osi_misc.c | 9 ++++++++-
src/cf/linux-kernel-func.m4 | 3 +++
2 files changed, 11 insertions(+), 1 deletions(-)
OpenAFS Master Repository