OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-474-ga455452
Gerrit Code Review
gerrit@openafs.org
Thu, 10 Oct 2019 23:33:55 -0400
The following commit has been merged in the master branch:
commit a455452d7ee98d160620925bb8a0e3d0f4dfd7ec
Author: Cheyenne Wills <cwills@sinenomine.net>
Date: Tue Oct 1 12:14:41 2019 -0600
LINUX 5.3: Add comments for fallthrough switch cases
With commit 6e0f1c3b45102e7644d25cf34395ca980414317f (LINUX: Honor
--enable-checking for libafs) building libafs against a linux 5.3
kernel compiles with errors due to fall through in case statements when
--enable-checking / --enable-warning is used.
e.g.
src/opr/jhash.h:82:17: error: this statement may fall through
[-Werror=implicit-fallthrough=]
case 3 : c+=k[2];
~^~~~~~
The GCC compiler will disable the implicit-fallthrough check for case
statements that contain a "special" comment ( /* fall through */ ).
Add the 'fall through' comment to indicate where fall throughs are
acceptable.
This commit only adds comments and does not alter any executable code.
The -Wimplicit-fallthrough flag was enabled globally in the linux kernel
build in 5.3-rc2 (commit: a035d552a93bb9ef6048733bb9f2a0dc857ff869
Makefile: Globally enable fall-through warning)
Change-Id: Ie6ca425e04b53a22d07b415cb8afd172af7e8081
Reviewed-on: https://gerrit.openafs.org/13881
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/afs/LINUX/osi_vnodeops.c | 1 +
src/opr/jhash.h | 3 +++
src/rx/xdr.c | 4 ++--
3 files changed, 6 insertions(+), 2 deletions(-)
--
OpenAFS Master Repository