OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-570-g7df5c00
Gerrit Code Review
Fri, 17 Apr 2020 19:57:26 -0400
The following commit has been merged in the master branch:
Author: Andrew Deason <firstname.lastname@example.org>
Date: Sun Apr 12 22:40:14 2020 -0500
FBSD: Remove unused 'wantparent' logic
In afs_vop_lookup, the 'wantparent' variable doesn't actually change
any logic in the function. In the if() clause that it's used, the
value of 'wantparent' is only ever used if cnp->cn_nameiop is RENAME
and ISLASTCN is set. But if both of those are true, then the second
half of the if() conditional will always be true, so the value of
'wantparent' doesn't matter.
So to remove this confusing unused logic, remove the 'wantparent'
local var, and all its associated logic.
Issue spotted by email@example.com.
Tested-by: BuildBot <firstname.lastname@example.org>
Reviewed-by: Benjamin Kaduk <email@example.com>
src/afs/FBSD/osi_vnodeops.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
OpenAFS Master Repository