OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-573-g0ee53d2
Gerrit Code Review
gerrit@openafs.org
Fri, 17 Apr 2020 20:22:01 -0400
The following commit has been merged in the master branch:
commit 0ee53d2fe9341e60f420662749d5ae8c6d4b5f24
Author: Tim Creech <tcreech@umd.edu>
Date: Fri Dec 13 22:24:57 2019 -0500
FBSD: Build vnode_if.h before libafs objs
Currently, if we are building with -j2 or higher, we can easily fail
to build some libafs objects because vnode_if.h does not exist yet.
vnode_if.h is generated by the FreeBSD build, but none of our objects
depend on it, so during parallel builds it may not be available by the
time we build, for example, src/external/heimdal/hcrypto/sha256.c.
This results in build errors that can look like this:
--- sha256-kernel.o ---
cc -I. -I.. -I../nfs [...]/src/external/heimdal/hcrypto/sha256.c
In file included from [...]/src/external/heimdal/hcrypto/sha256.c:34:
In file included from [...]/src/crypto/hcrypto/kernel/config.h:30:
In file included from [...]/src/afs/sysincludes.h:354:
/usr/src/sys/sys/vnode.h:588:10: fatal error: 'vnode_if.h' file not found
#include "vnode_if.h"
^~~~~~~~~~~~
1 error generated.
*** [sha256-kernel.o] Error code 1
make[4]: stopped in [...]/src/libafs/MODLOAD
1 error
To avoid this, make all of our libafs objects depends on vnode_if.h.
[adeason@dson.org: Expanded commit message.]
Change-Id: I5a7a6ece8d5fbe6cf1a5b94451c8e8ae93fdc55f
Reviewed-on: https://gerrit.openafs.org/13983
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/libafs/MakefileProto.FBSD.in | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
--
OpenAFS Master Repository