OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-664-gb968875

Gerrit Code Review
Fri, 28 Aug 2020 12:12:59 -0400

The following commit has been merged in the master branch:
commit b968875a342ba8f11378e76560b46701f21391e8
Author: Yadavendra Yadav <>
Date:   Fri Aug 21 01:54:00 2020 +0530

    afs: Avoid NatPing event on all connection
    Inside release_conns_user_server, connection vector is traversed and after
    destroying a connection new eligible connection is found on which NatPing
    event will be set. Ideally there should be only one connection on which
    NatPing should be set but in current code while traversing all connection
    of server a NatPing event is set on all connections to that server. In
    cases where we have large number of connection to a server this can lead
    to huge number of “RX_PACKET_TYPE_VERSION” packets sent to a server.
    Since this happen during Garbage collection of user structs, to simulate
    this issue below steps were tried
      - had one script which “cd” to a volume mount and then script sleeps for
        large time.
      - Ran one infinite while loop where above script was called using PAG
        based tokens (As new connection will be created for each PAG)
      - Instrumented the code, so that we hit above code segment where NatPing
        event is set. Mainly reduced NOTOKTIMEOUT to 60 sec.
    To fix this issue set NatPing on one connection and once it is set break
    from “for” loop traversing the server connection.
    Change-Id: Ia38cec0403fde76cdd59aa664bd261481e2edee6
    Tested-by: BuildBot <>
    Reviewed-by: Benjamin Kaduk <>
    Reviewed-by: Andrew Deason <>

 src/afs/afs_conn.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

OpenAFS Master Repository