OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-599-g13e44b2

[Gerrit Code Review]

The following commit has been merged in the master branch:
commit 13e44b2b200cd99d0df4e03cf6413d3a6915783f
Author: Andrew Deason <adeason@dson.org>
Date:   Mon Nov 18 23:17:12 2019 -0600

    afs: Refactor osi_vnhold/AFS_FAST_HOLD
    
    Make a few changes to osi_vnhold and AFS_FAST_HOLD:
    
    - Currently, the second argument of osi_vnhold ("retry") is never used
      by any implementation. Get rid of it.
    
    - AFS_FAST_HOLD() is the same as osi_vnhold(). Get rid of
      AFS_FAST_HOLD, and just have all callers use osi_vnhold instead.
    
    - Allow osi_vnhold to return an error, and adjust callers to handle
      it.
    
    - Change osi_vnhold to be a real function, instead of a macro, to make
      nontrivial implementations less cumbersome.
    
    Most platforms never return an error from osi_vnhold(), so the added
    code paths to check the return value of osi_vnhold() will not trigger.
    However, this lets us add future commits that do make osi_vnhold()
    return an error.
    
    Change-Id: Id2f3717be6c305d06305685247ac789815e1ebf7
    Reviewed-on: https://gerrit.openafs.org/13971
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/afs/AIX/osi_machdep.h       |    2 -
 src/afs/AIX/osi_vcache.c        |    6 ++++
 src/afs/DARWIN/osi_machdep.h    |    1 -
 src/afs/DARWIN/osi_vcache.c     |    7 ++++
 src/afs/DARWIN/osi_vfsops.c     |    2 +-
 src/afs/DARWIN/osi_vm.c         |    2 +-
 src/afs/FBSD/osi_machdep.h      |    2 -
 src/afs/FBSD/osi_vcache.c       |    6 ++++
 src/afs/HPUX/osi_machdep.h      |    1 -
 src/afs/HPUX/osi_vcache.c       |    7 ++++
 src/afs/IRIX/osi_machdep.h      |    2 -
 src/afs/IRIX/osi_vcache.c       |    6 ++++
 src/afs/LINUX/osi_machdep.h     |    1 -
 src/afs/LINUX/osi_vcache.c      |   12 +++++++-
 src/afs/NBSD/osi_machdep.h      |    1 -
 src/afs/NBSD/osi_vcache.c       |    7 ++++
 src/afs/OBSD/osi_machdep.h      |    1 -
 src/afs/OBSD/osi_vcache.c       |    5 +++
 src/afs/SOLARIS/osi_machdep.h   |   13 --------
 src/afs/SOLARIS/osi_vcache.c    |   16 ++++++++++
 src/afs/SOLARIS/osi_vfsops.c    |    2 +-
 src/afs/UKERNEL/osi_machdep.h   |    2 -
 src/afs/UKERNEL/osi_vcache.c    |    6 ++++
 src/afs/VNOPS/afs_vnop_fid.c    |    2 +-
 src/afs/VNOPS/afs_vnop_lookup.c |   16 ++++++++--
 src/afs/VNOPS/afs_vnop_remove.c |    2 +-
 src/afs/afs.h                   |    2 +-
 src/afs/afs_callback.c          |   16 ++++------
 src/afs/afs_daemons.c           |    2 +-
 src/afs/afs_osi.h               |   12 +++++--
 src/afs/afs_osidnlc.c           |    6 +++-
 src/afs/afs_pioctl.c            |    4 ++-
 src/afs/afs_vcache.c            |   63 ++++++++++++++++++++------------------
 src/afs/afs_volume.c            |    4 ++-
 34 files changed, 156 insertions(+), 83 deletions(-)

-- 
OpenAFS Master Repository