OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_0-21-gea9e5e8
Gerrit Code Review
gerrit@openafs.org
Fri, 23 Oct 2020 12:48:02 -0400
The following commit has been merged in the master branch:
commit ea9e5e8519dc486cfb019447ee5d695de104079d
Author: Andrew Deason <adeason@sinenomine.net>
Date: Thu Jul 18 16:21:10 2019 -0500
afs: Handle osi_NewVnode failures
Currently, code inside afs_vcache.c assumes that osi_NewVnode always
returns non-NULL, which means that osi_NewVnode must panic if it
cannot create a new vnode.
All of the callers of afs_GetVCache, afs_NewVCache, etc, already
handle getting a NULL return, though (after all, the given fid may not
exist or be inaccessible due to network errors, etc). So, just
propagate NULL returns from osi_NewVnode up to our callers, to avoid
panics in these situations.
Modify osi_NewVnode on many arches to return an error on allocation
failure, instead of panic'ing.
Change-Id: Ib578b1747590bdf65327d4674e0849811ed999eb
Reviewed-on: https://gerrit.openafs.org/13701
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Yadavendra Yadav <yadayada@in.ibm.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/afs/AIX/osi_vcache.c | 4 +++-
src/afs/DARWIN/osi_vcache.c | 4 +++-
src/afs/FBSD/osi_vcache.c | 3 +++
src/afs/IRIX/osi_vcache.c | 3 +++
src/afs/LINUX/osi_vcache.c | 9 +++++++--
src/afs/NBSD/osi_vcache.c | 3 +++
src/afs/OBSD/osi_vcache.c | 3 +++
src/afs/SOLARIS/osi_vcache.c | 4 +++-
src/afs/afs_vcache.c | 9 +++++++++
9 files changed, 37 insertions(+), 5 deletions(-)
--
OpenAFS Master Repository