OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_6-49-g5c476b9

Gerrit Code Review
Fri, 23 Oct 2020 19:06:49 -0400

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 5c476b91fd2259e9c34070be8ba201dd471ad974
Author: Andrew Deason <>
Date:   Thu Jul 13 17:40:21 2017 -0500

    afs: Change VerifyVCache2 calls to VerifyVCache
    afs_VerifyVCache is a macro that (on most platforms) effectively
    expands to:
        if ((avc->f.states & CStatd)) {
            return 0;
        } else {
            return afs_VerifyVCache2(...);
    Some callers call afs_VerifyVCache2 directly, since they already check
    for CStatd for other reasons. A few callers currently call
    afs_VerifyVCache2, but without guaranteeing that CStatd is not set.
    Specifically, in afs_getattr and afs_linux_VerifyVCache, CStatd could
    be set while afs_CreateReq drops GLOCK. And in afs_linux_readdir,
    CStatd could be cleared at multiple different points before the
    VerifyVCache call.
    This can result in afs_VerifyVCache2 acquiring a write-lock on the
    vcache, even when CStatd is already set, which is an unnecessary
    performance hit.
    To avoid this, change these call sites to use afs_VerifyVCache instead
    of calling afs_VerifyVCache2 directly, which skips the write lock when
    CStatd is already set.
    Tested-by: BuildBot <>
    Reviewed-by: Benjamin Kaduk <>
    (cherry picked from commit a05d5b7503e466e18f5157006c1de2a2f7d019f7)
    Change-Id: I05bdcb7f10930ed465c24a8d7e51077a027b1a4b
    Tested-by: BuildBot <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Cheyenne Wills <>
    Reviewed-by: Stephan Wiesand <>

 src/afs/LINUX/osi_vnodeops.c   |    4 ++--
 src/afs/VNOPS/afs_vnop_attrs.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

OpenAFS Master Repository