OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-65-g7739d1e

Gerrit Code Review
Thu, 5 Aug 2021 11:43:29 -0400

The following commit has been merged in the master branch:
commit 7739d1e967177686e91a6ea86c73b404515a1c0d
Author: Jeffrey Altman <>
Date:   Fri Oct 2 19:51:06 2020 -0400

    rx: compare RX_ACK_TYPE_ACK as a bit-field
    The rx_ackPacket.acks array (the SACK table) consists of up to 255
    octets.  Each octet stores either the value zero (RX_ACK_TYPE_NACK)
    or one (RX_ACK_TYPE_ACK).  Effectively only bit-zero of each octet
    is used.
    The rx_ackPacket.acks array cannot be enlarged but one possible
    method of encoding the ACK/NACK state for packets when the
    window size is greater than 255 is to use bits 1-7 of each
    This change alters the test for ACK vs NACK to be a bit comparison
    instead of a equality comparison.  This change permits RX to be
    compatible with any future use of bits 1-7.
    No peer that treats the SACK table as bytes can ever send more
    than 255 packets regardless of the advertised receive window.
    Therefore, existing peers will never receive a SACK table with
    more than 255 packets worth of bits.
    Change-Id: I4dfcdc9ea18e060eeb257832297f557b7109e93a
    Tested-by: BuildBot <>
    Reviewed-by: Benjamin Kaduk <>

 src/rx/rx.c |   12 +++++++-----
 src/rx/rx.h |   25 +++++++++++++++++++------
 2 files changed, 26 insertions(+), 11 deletions(-)

OpenAFS Master Repository