OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-38-g0d6b9de

[Gerrit Code Review]

The following commit has been merged in the master branch:
commit 0d6b9defb36cb94f3d34b058f00055e9e99d85fc
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri May 21 12:38:01 2021 -0400

    libadmin: Let xdr allocate rpc output strings
    
    In most functions, the libadmin library provides fixed sized buffers for
    RPC output strings instead of letting xdr allocate the output string.
    Unfortunately the fixed sized buffers do not account for the terminating
    nul char when the output string is the maximum length possible for the
    xdr output strings.
    
    To avoid potential buffer overflows, and to allow for larger xdr string
    sizes in the future, convert these to xdr allocated strings and use safe
    string functions to copy the results to the application buffers. Fail
    with an error if the application buffer is too small, instead of
    overflowing the buffer or truncating results.
    
    Thanks to Cheyenne Wills for pointing out this issue.
    
    Change-Id: I963e1b790417863c036e897811c86a634d1d4e7f
    Reviewed-on: https://gerrit.openafs.org/14626
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>

 src/libadmin/adminutil/afs_AdminUtilErrors.et |    1 +
 src/libadmin/adminutil/afs_utilAdmin.c        |   26 +++++--
 src/libadmin/bos/afs_bosAdmin.c               |   94 +++++++++++++++++++-----
 3 files changed, 94 insertions(+), 27 deletions(-)

-- 
OpenAFS Master Repository