OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-42-g9ae5b59

Gerrit Code Review gerrit@openafs.org
Sat, 26 Jun 2021 00:10:30 -0400


The following commit has been merged in the master branch:
commit 9ae5b599c7289a6f3ea2b03f2646402da182bb5d
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Jun 22 20:02:18 2021 -0400

    bos: Let xdr allocate rpc output strings
    
    The bos client provides fixed sized buffers on the stack for RPC output
    strings instead of letting xdr allocate output strings.  Unfortunately,
    the fixed sized buffers do not account for the terminating nul char when
    the output string is the maximum size defined for the bozo RPCs.
    
    To avoid potential buffer overflows, and to allow for larger xdr string
    sizes in the future, convert these to xdr allocated strings. Be sure to
    always free the xdr allocated strings.
    
    The following bozo RPCs have xdr output strings, and are addressed in
    this commit:
    
    BOZO_EnumerateInstance
    BOZO_GetCellHost
    BOZO_GetCellName
    BOZO_GetInstanceInfo
    BOZO_GetInstanceParm
    BOZO_GetInstanceStrings
    BOZO_GetStatus
    BOZO_ListSUsers
    
    Thanks to Cheyenne Wills for pointing out this issue.
    
    Change-Id: I7fb48ff6766420a2d84723e1663ff24e86313ccf
    Reviewed-on: https://gerrit.openafs.org/14650
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/bozo/bos.c |  130 +++++++++++++++++++++++++++++++------------------------
 1 files changed, 73 insertions(+), 57 deletions(-)

-- 
OpenAFS Master Repository