OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-142-ga737126

[Gerrit Code Review]

The following commit has been merged in the master branch:
commit a73712603588e9819127c5ec99e5a381bb4c69f5
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Tue Nov 23 15:31:33 2021 -0600

    tests: Put tmp dirs in objdir, not /tmp
    
    Currently, all tests that use afstest_mkdtemp() generate a temporary
    dir in /tmp, which is removed when the test is done (unless MAKECHECK
    isn't set, or the test prematurely exits/crashes). The /tmp dir on a
    system may not be the best choice; it may be limited in size, and it's
    visible to other users, which is annoying if we are littering the dir
    with afs_XXXXXX dirs if broken tests are running during development.
    
    Instead, use a tmp dir in the objdir of the current build
    (specifically, tests/tmp/). Since this is the same dir we're building
    the tree in, we must be able to write to it and it should have plenty
    of space. And it will almost certainly get cleaned up eventually, even
    with broken tests, since it will get removed when the build tree is
    inevitably removed.
    
    While we're doing this, run the paths from afstest_src_path and
    afstest_obj_path through realpath(), so our tmp paths (and other
    paths) look a little cleaner, and don't look like
    /home/user/openafs/tests/../tests/tmp/foo.
    
    Change-Id: I6633f58ac1f6ef34e33b51cc19d3bff7a4f3fdb0
    Reviewed-on: https://gerrit.openafs.org/14864
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>

 tests/common/files.c | 33 ++++++++++++++++++++++++++++-----
 1 file changed, 28 insertions(+), 5 deletions(-)

-- 
OpenAFS Master Repository