OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_8_1-28-g97b8fe1

Gerrit Code Review gerrit@openafs.org
Thu, 4 Aug 2022 12:31:57 -0400


The following commit has been merged in the openafs-stable-1_8_x branch:
commit 97b8fe13831d575ada7ea85c794637d1b4dd3493
Author: Cheyenne Wills <cwills@sinenomine.net>
Date:   Thu Jun 2 10:56:39 2022 -0600

    Add more 'fall through' switch comments
    
    Commit a455452d (LINUX 5.3: Add comments for fallthrough switch cases)
    added the special /* fall through */ comment to various switch/case
    blocks, in order to avoid implicit-fallthrough warnings from causing
    the build to fail when building the Linux kernel module.
    
    In this commit, add additional /* fall through */ comments to the rest
    of the tree where falling through is intentional. Add a "break;" in one
    place in dumptool.c where falling through seems like a mistake, and flag
    certain functions as AFS_NORETURN to avoid needing to explicitly break
    or fallthrough.
    
    Check for the availability of the -Wimplicit-fallthrough compiler flag
    and use it when --enable-checking is set, to prevent additional cases
    from creeping into the tree.
    
    Note: the -Wimplicit-fallthrough compiler flag was added in gcc 7.
    
    Reviewed-on: https://gerrit.openafs.org/14125
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 929d501421579290ce1d4f9aabe45980e5458a9a)
    
    Change-Id: I57d19d715fe61e9125b0b9efc8ae36934001bb10
    Reviewed-on: https://gerrit.openafs.org/14969
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

 src/butc/dump.c                      |  3 +--
 src/cf/osconf.m4                     |  5 +++++
 src/cmd/cmd.c                        |  2 +-
 src/opr/jhash.h                      | 24 ++++++++++++------------
 src/tools/dumpscan/afsdump_dirlist.c |  2 +-
 src/tools/dumpscan/afsdump_extract.c |  2 +-
 src/tools/dumpscan/afsdump_scan.c    |  2 +-
 src/tools/dumpscan/dumptool.c        |  1 +
 src/tools/dumpscan/parsevnode.c      |  2 +-
 src/vol/salvaged.c                   |  1 +
 src/vol/salvsync-server.c            |  2 +-
 src/vol/volume.c                     |  3 +++
 12 files changed, 29 insertions(+), 20 deletions(-)

-- 
OpenAFS Master Repository