OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-227-gc9ac7cd

Gerrit Code Review gerrit@openafs.org
Thu, 1 Dec 2022 21:23:08 -0500


The following commit has been merged in the master branch:
commit c9ac7cdfb6365e3fc1914de80019a10328de1f4f
Author: Cheyenne Wills <cwills@sinenomine.net>
Date:   Mon Nov 14 15:55:41 2022 -0700

    crypto: Define krb5_keytype as krb5_enctype
    
    When building with clang-16 and configured with --enable-checking, the
    external source heimdal/krb5/crypto.c used in src/crypto/rfc3961 fails
    with the following error:
    
      src/external/heimdal/krb5/crypto.c:702:28
       error: implicit conversion from enumeration type 'krb5_enctype' (aka
       'enum ENCTYPE') to different enumeration type 'krb5_keytype' (aka
       'enum krb5_keytype') [-Werror,-Wenum-conversion]
           *keytype = e->keytype->type; /* XXX */
                    ~ ~~~~~~~~~~~~^~~~
    
    Replace the enum definition of krb5_keytype with a typedef to
    krb5_enctype and create an anonymous enum mapping of KEYTYPE_ARCFOUR to
    ETYPE_ARCFOUR_HMAC_MD5.
    
    It should be noted that krb5_keytype and KEYTYPE_ARCFOUR are only used
    by the external file src/external/heimdal/krb5/crypto.c
    
    Changing the type for krb5_keytype was suggested by Andrew Deason
    (adeason@sinenomine.net).
    
    Change-Id: I6b4e94cabe98f9b33df0c91cb75bc84b9f9e3dee
    Reviewed-on: https://gerrit.openafs.org/15189
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/crypto/rfc3961/krb5_locl.h | 37 ++++++++++++++++++++++++++++---------
 1 file changed, 28 insertions(+), 9 deletions(-)

-- 
OpenAFS Master Repository