OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-165-g82c14b9
Gerrit Code Review
gerrit@openafs.org
Thu, 2 Jun 2022 00:08:24 -0400
The following commit has been merged in the master branch:
commit 82c14b9a667174f044b7421e6e081ad323720a67
Author: Cheyenne Wills <cwills@sinenomine.net>
Date: Wed May 11 08:48:52 2022 -0600
afsd: Avoid fscanf overflows when paring cacheinfo
clang-14 is producing the following diagnostic:
afsd.c:581:44: error: 'fscanf' may overflow; destination buffer in
argument 3 has size 1024, but the corresponding specifier may
require size 1025 [-Werror,-Wfortify-source]
fscanf(cachefd, "%1024[^:]:%1024[^:]:%d", tCacheMountDir,
fscanf is being used to parse the contents of a file and the buffer
sizes are hardcoded. Simply increase the size of the 2 buffers by 1.
The diagnostic warning is changed to an error when configured with
--enable-checking.
Change-Id: Iefbc4e87242232531a266e876fe779476b42fb62
Reviewed-on: https://gerrit.openafs.org/14958
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/afsd/afsd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
OpenAFS Master Repository