OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-168-g573be02
Gerrit Code Review
gerrit@openafs.org
Wed, 8 Jun 2022 23:33:00 -0400
The following commit has been merged in the master branch:
commit 573be0228778873c0d445263fb09989918bea4c1
Author: Cheyenne Wills <cwills@sinenomine.net>
Date: Tue Mar 1 15:35:07 2022 -0700
cf: Use -Werror when checking for -Wno-* flags
When detecting valid compiler flags clang behaves differently than gcc
for certain types of flags. Specifically, gcc will ignore an unknown
"-Wno-someflag" while clang will issue a warning. If using clang and
--enable-checking is specified, this difference causes a build failure
because the warning for the unknown flag is turned into an error.
The autoconf macro AX_APPEND_COMPILE_FLAGS (via the underlying macro
AX_CHECK_COMPILE_FLAGS) looks specifically for errors and not warnings
to determine if the flag is valid. In order to properly catch the above
type of unknown compiler flags, a '-Werror' must be passed as an
extra-flag.
Update the autoconf functions that use AX_APPEND_COMPILE_FLAGS to use
'-Werror' as an extra flag when testing for "-Wno-..." flags.
Note, for gcc, the test may (incorrectly) think that the compiler
supports the given flag, but that is okay, since the flag will be
ignored by gcc during the build without raising any warnings or errors.
Change-Id: I9e4dabf04a3b019cb1ea58a4b2ac1cf0fc8d1e71
Reviewed-on: https://gerrit.openafs.org/14900
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/cf/linux-checks.m4 | 2 +-
src/cf/osconf.m4 | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
--
OpenAFS Master Repository