OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_8_1-2-g8db804e
Gerrit Code Review
gerrit@openafs.org
Thu, 26 May 2022 11:50:46 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit 8db804eb1ec3f6a4b41dafff31f4805688a3da60
Author: Andrew Deason <adeason@sinenomine.net>
Date: Thu Jul 18 16:21:10 2019 -0500
afs: Handle osi_NewVnode failures
Currently, code inside afs_vcache.c assumes that osi_NewVnode always
returns non-NULL, which means that osi_NewVnode must panic if it
cannot create a new vnode.
All of the callers of afs_GetVCache, afs_NewVCache, etc, already
handle getting a NULL return, though (after all, the given fid may not
exist or be inaccessible due to network errors, etc). So, just
propagate NULL returns from osi_NewVnode up to our callers, to avoid
panics in these situations.
Modify osi_NewVnode on many arches to return an error on allocation
failure, instead of panic'ing.
Reviewed-on: https://gerrit.openafs.org/13701
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Yadavendra Yadav <yadayada@in.ibm.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit ea9e5e8519dc486cfb019447ee5d695de104079d)
Change-Id: I2a3c5aac44a57093caee4008b86420ed05c66eb7
Reviewed-on: https://gerrit.openafs.org/14927
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/afs/AIX/osi_vcache.c | 4 +++-
src/afs/DARWIN/osi_vcache.c | 4 +++-
src/afs/FBSD/osi_vcache.c | 3 +++
src/afs/IRIX/osi_vcache.c | 3 +++
src/afs/LINUX/osi_vcache.c | 9 +++++++--
src/afs/NBSD/osi_vcache.c | 3 +++
src/afs/OBSD/osi_vcache.c | 3 +++
src/afs/SOLARIS/osi_vcache.c | 4 +++-
src/afs/afs_vcache.c | 9 +++++++++
9 files changed, 37 insertions(+), 5 deletions(-)
--
OpenAFS Master Repository