OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_9-72-gc8a92c4

Gerrit Code Review
Thu, 13 Apr 2023 15:47:29 -0400

The following commit has been merged in the openafs-stable-1_8_x branch:
commit c8a92c4a7e1badfaf81517303440cd9ac7a55dd0
Author: Michael Meffie <>
Date:   Thu Mar 15 18:53:59 2018 -0400

    roken: do not clobber __attribute__
    The roken-common.h header defines an empty macro called __attribute__
    when HAVE___ATTRIBUTE__ is not defined. This macro conditionally removes
    the `format' function attributes in the roken headers at compile time.
    Unfortunately, the empty __attribute__ macro will also clobber other
    attribute types encountered after the roken.h header inclusion.
    This is not an issue when building under gcc or clang, since the empty
    attribute macro will not be defined. However Solaris Studio supports a
    subset of the function attribute types, with `format' not currently
    supported. This means roken will define an empty __attribute__ macro,
    which prevents the use of other attribute types.
    This commit does not change the roken files directly because they are
    external.  Instead, the processing of the file has been
    updated to undefine the __attribute__ macro at the end of the generated
    roken.h header.
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Benjamin Kaduk <>
    Tested-by: BuildBot <>
    (cherry picked from commit 388eaec3452ed4b18a95ee34efcbe4cf64814701)
    Change-Id: Id93ec414a59a2f5866e503601b7e42bbb4f8d66a
    Tested-by: BuildBot <>
    Reviewed-by: Ben Huntsman <>
    Reviewed-by: Michael Meffie <>
    Reviewed-by: Cheyenne Wills <>
    Reviewed-by: Stephan Wiesand <>

 src/roken/  | 7 +++++--
 src/roken/roken-post.h | 8 ++++++++
 2 files changed, 13 insertions(+), 2 deletions(-)

OpenAFS Master Repository