OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_9-10-g581450c
Gerrit Code Review
gerrit@openafs.org
Fri, 20 Jan 2023 08:28:56 -0500
The following commit has been merged in the openafs-stable-1_8_x branch:
commit 581450c74c57680eeb89bf937b4d42936df6196b
Author: Marcio Barbosa <mbarbosa@sinenomine.net>
Date: Wed Apr 6 20:59:56 2022 +0000
afs: Replace strcpy &co by safer alternatives
In addition to being unsafe, these functions (strcpy, strncpy, strcat,
and sprintf) are deprecated on macOS. Replace these functions by safer
alternatives (strlcpy, strlcat, snprintf, and afs_strdup).
Notice that, in order to use afs_strdup(), this commit adds the afs_util
library to the AFSPAGOBJS list. Given that afs_strcasecmp() is also
implemented in afs_util.c, src/crypto/hcrypto/kernel/strcasecmp.c can be
removed from the tree.
No functional change should be incurred by this commit.
This commit is a continuation of a patch initially developed by
cwills@sinenomine.net.
Reviewed-on: https://gerrit.openafs.org/14743
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit 419f0cd7aa75719dcf4df97e603ad4f0d936ddd9)
[cwills@sinenomine.net]
Part of the (419f0cd7aa) changes to afs_callback.c were pulled in to a
1.8.x specific commit:
"afs: Avoid unbounded string copy in SRXAFSCB_GetLock()" (79a04c344)
In order to resync the code, the include roken.h in afs_callback.c
introduced in that commit needed to be removed.
Change-Id: Ica0e9bdc82de2b1e89e6d4b513e775b2809fbc34
Reviewed-on: https://gerrit.openafs.org/15240
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Harish Sharma <Harish.Sharma1@ibm.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/afs/DARWIN/osi_inode.c | 6 ++-
src/afs/DARWIN/osi_vfsops.c | 10 +++-
src/afs/UKERNEL/afsincludes.h | 1 +
src/afs/VNOPS/afs_vnop_lookup.c | 91 ++++++++++++++++++++++++----------
src/afs/VNOPS/afs_vnop_symlink.c | 2 +-
src/afs/afs_callback.c | 3 --
src/afs/afs_cell.c | 2 +-
src/afs/afs_daemons.c | 17 +++++--
src/afs/afs_dynroot.c | 44 ++++++++--------
src/afs/afs_icl.c | 12 +++--
src/afs/afs_init.c | 2 +-
src/afs/afs_mariner.c | 34 ++++++++-----
src/afs/afs_pag_call.c | 2 +-
src/afs/afs_pag_cred.c | 7 +--
src/afs/afs_pioctl.c | 16 ++++--
src/afs/afs_volume.c | 7 +--
src/crypto/hcrypto/kernel/libafsdep | 1 -
src/crypto/hcrypto/kernel/strcasecmp.c | 32 ------------
src/dir/dir.c | 21 ++++++--
src/dir/test/Makefile.in | 2 +-
src/libafs/Makefile.common.in | 4 +-
src/rx/rx_kcommon.c | 2 +-
src/rx/rx_packet.c | 2 +-
23 files changed, 186 insertions(+), 134 deletions(-)
--
OpenAFS Master Repository