OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_9-97-g12ce31c
Gerrit Code Review
gerrit@openafs.org
Thu, 4 May 2023 11:46:06 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit 12ce31ce1dbd86dff47a036b36ce6ad506bd7b75
Author: Cheyenne Wills <cwills@sinenomine.net>
Date: Tue Apr 25 10:37:01 2023 -0600
Linux: Do not initialize msghdr's msg_iter/msg_iov
Since the initial Linux commit (2.6.12-rc2) the Linux function
kernel_recvmsg() handles the initialization of the msghdr members
related to the iov (msghdr.msg_iter and for earlier kernels
msghdr.msg_iov and msghdr.msg_iovlen).
The code in osi_NetReceive for Linux unnecessarily initializes these
structure members prior to calling kernel_recvmsg().
Remove the unnecessary code from osi_NetReceive along with the
surrounding preprocessor check for STRUCT_MSGHDR_HAS_MSG_ITER. Since
this is the only location that uses this define, also remove the
associated autoconf test.
NOTE: This was discovered while investigating changes needed for
Linux 6.4, due to: "iov_iter: add iter_iovec() helper" (de4f5fed3f)
which renamed the Linux structure iter_iovec's member iov to __iov.
Since the openafs code that was affected by the Linux 6.4 change is
being removed as unnecessary, this commit is not Linux 6.4 specific,
but effects all versions of Linux.
Reviewed-on: https://gerrit.openafs.org/15408
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 5a7630acfd8bfd462b633475a6e195d9dbdfb451)
Change-Id: I3a803f76ab84f1e055e91cf4f2be96440f141746
Reviewed-on: https://gerrit.openafs.org/15410
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/cf/linux-kernel-struct.m4 | 1 -
src/rx/LINUX/rx_knet.c | 7 -------
2 files changed, 8 deletions(-)
--
OpenAFS Master Repository