OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_11-3-g9f052c1

[Gerrit Code Review]

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 9f052c137d1184a783c8ac3182c3544b275484f5
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Sat Jan 9 12:50:03 2021 -0600

    afs: Remove SRXAFSCB_GetDE
    
    The GetDE RPC has been commented out from afscbint.xg effectively
    since it was introduced, but we still define the SRXAFSCB_GetDE server
    stub for it.
    
    This is useless, but also potentially dangerous, since the stub
    routine just returns success, without populating the output arguments.
    One of the output arguments is a string, and so if this RPC is
    actually run, the rxgen-generated server code will try to xdr_string()
    that string. Since we never set it to anything, this will result in
    xdr_string trying to dereference a NULL pointer.
    
    None of this actually happens currently, since the GetDE RPC is
    commented out. But to avoid the above situation if it's ever
    uncommented, remove the useless SRXAFSCB_GetDE function.
    
    Reviewed-on: https://gerrit.openafs.org/14488
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    (cherry picked from commit 444a971edc47c34efbefed6e332ee6e843ae072b)
    
    Change-Id: I83846d79ce3143571923cb6023075620091f093d
    Reviewed-on: https://gerrit.openafs.org/15681
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/afs/afs_callback.c | 11 -----------
 1 file changed, 11 deletions(-)

-- 
OpenAFS Master Repository