OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_12-4-ge24033d

Gerrit Code Review gerrit@openafs.org
Thu, 22 Aug 2024 12:10:12 -0400


The following commit has been merged in the openafs-stable-1_8_x branch:
commit e24033ddabddbc3da34818811d07ee99ef60da65
Author: Cheyenne Wills <cwills@sinenomine.net>
Date:   Wed Jun 12 14:24:01 2024 -0600

    afs: avoid empty-body warning
    
    With Linux 6.10 commit:
        "kbuild: turn on -Wextra by default" (f5982cceb3)
    there are additional compiler warnings that can turn
    into build errors when --enable-checking is used.
    
        "error: suggest braces around empty body in an ‘if’
         statement [-Werror=empty-body]"
    
    when there is an empty body, e.g.
        if (foo)
            ;
    
    Most cases are due to the macros afs_PutCell and afs_PutServer which are
    "empty" macros.
    
    Update the afs_PutCell and afs_PutServer macros so they expand to
      do {} while(0)
    
    Add a comment at the definitions for afs_PutCell and afs_PutServer to
    document the reason for keeping them.
    
    Add braces to conditionals that have an empty body.
    
    There are no functional changes with this commit.
    
    Reviewed-on: https://gerrit.openafs.org/15766
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    (cherry picked from commit d8b56f21994ce66d8daebb7d69e792f34c1a19ed)
    
    Change-Id: I0617aeba36b638ae36678043216e2b4c145921b7
    Reviewed-on: https://gerrit.openafs.org/15799
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/afs/afs.h         | 6 ++++--
 src/afs/afs_cbqueue.c | 4 +++-
 2 files changed, 7 insertions(+), 3 deletions(-)

-- 
OpenAFS Master Repository