OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-310-g3683f15
Gerrit Code Review
gerrit@openafs.org
Tue, 20 Feb 2024 01:03:00 -0500
The following commit has been merged in the master branch:
commit 3683f15278e34e13d7272928eaf666f0acc4e1e9
Author: Cheyenne Wills <cwills@sinenomine.net>
Date: Mon Feb 12 08:25:47 2024 -0700
afs: Add includes to pick up function prototypes
The functions defined in LINUX/osi_crypto.c, osi_pagecopy.c,
osi_probe.c, and osi_syscall.c have function prototypes defined in
existing header files, however either due to missing includes or
preprocessor conditionals that skip the includes, these function
prototypes are not being pulled in.
These functions are flagged due to missing prototypes when building
against a Linux 6.8 kernel (which sets the -Wmissing-declarations and
-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:
'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).
When building against a kernel with CONFIG_WERROR=y, the build fails.
Add the necessary includes to osi_crypto.c and osi_pagecopy.c and
re-arrange the includes in osi_probe.c and osi_syscall.c to ensure that
the function prototypes are present when building the Linux kernel
module.
Change-Id: Idcb409b1c25354b1b8b3bff286000a189651bbf6
Reviewed-on: https://gerrit.openafs.org/15641
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/afs/LINUX/osi_crypto.c | 3 +++
src/afs/LINUX/osi_pagecopy.c | 1 +
src/afs/LINUX/osi_probe.c | 8 ++++----
src/afs/LINUX/osi_syscall.c | 7 ++++---
4 files changed, 12 insertions(+), 7 deletions(-)
--
OpenAFS Master Repository