OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-314-g575d986

Gerrit Code Review gerrit@openafs.org
Thu, 29 Feb 2024 12:31:54 -0500


The following commit has been merged in the master branch:
commit 575d986aa6c18ac27ea42fb66ae8b8cb0e27fe6c
Author: Cheyenne Wills <cwills@sinenomine.net>
Date:   Mon Feb 12 08:59:32 2024 -0700

    afs: Add afs_xioctl prototyes to afs_prototypes.h
    
    Several .c files have external function prototypes for the afs_xioctl
    function, while the implementing files do not have the prototype.
    
    Move these prototypes into afs_prototypes.h so that the prototypes are
    available to both the caller and the implementation.
    
    Because the file holding the implementation does not have a prototypes,
    afs_xioctl() is being flagged when building against a Linux 6.8 kernel
    (which sets the -Wmissing-declarations and -Wmissing-prototypes compiler
    flags as default). Linux 6.8 commit:
     'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).
    
    When building against a Linux kernel with CONFIG_WERROR=y, the build
    fails.
    
    Note that the function afs_xioctl() has platform specific
    implementations.
    
    Change-Id: I0956daace8c9036a924b928e387eb4a2ea542bf1
    Reviewed-on: https://gerrit.openafs.org/15643
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/afs/FBSD/osi_vfsops.c    |  1 -
 src/afs/HPUX/osi_vfsops.c    |  2 +-
 src/afs/LINUX/osi_vnodeops.c |  4 ----
 src/afs/NBSD/osi_kmod.c      |  1 -
 src/afs/NBSD/osi_vfsops.c    |  1 -
 src/afs/OBSD/osi_vfsops.c    |  2 +-
 src/afs/SOLARIS/osi_vfsops.c |  1 -
 src/afs/afs_prototypes.h     | 17 +++++++++++++++++
 8 files changed, 19 insertions(+), 10 deletions(-)

-- 
OpenAFS Master Repository