OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-438-ge545f81

Gerrit Code Review gerrit@openafs.org
Tue, 9 Jul 2024 08:13:56 -0400


The following commit has been merged in the master branch:
commit e545f81f04013d6522e5d24cb7308990dbfe8320
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Wed Jul 3 20:00:01 2024 -0500

    Stop defining HC_DEPRECATED
    
    Heimdal's hcrypto declares various DES functions as deprecated. We use
    these functions in various files, and so we inhibit the
    -Wdeprecated-declarations warning so we can build with
    --enable-checking.
    
    Heimdal declares these functions as deprecated using the HC_DEPRECATED
    (or HC_DEPRECATED_CRYPTO) macro, which conditionally expands to
    __attribute__((deprecated)) depending on the platform. If we define
    HC_DEPRECATED ourselves to nothing before including the relevant header
    file, those functions will effectively not be declared deprecated. Some
    of our source files do this to avoid the -Wdeprecated-declarations
    warning.
    
    Some of our code does one of these to avoid the warning, and some does
    both. We should pick one or the other, and be consistent about it. In
    this commit, get rid of defining HC_DEPRECATED (and
    HC_DEPRECATED_CRYPTO) ourselves, and just inhibit the relevant warning
    the same way we do for all other warnings.
    
    All instances of this are also currently missing from the "Inhibited
    warnings" section in CODING. Add all instances to that list.
    
    Change-Id: I4d7ece94be22457ceefbe52b6ec286e67423e8cb
    Reviewed-on: https://gerrit.openafs.org/15776
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>

 CODING                    | 7 +++++++
 src/auth/authcon.c        | 1 -
 src/kauth/kaprocs.c       | 1 -
 src/kauth/krb_udp.c       | 1 -
 src/libafscp/afscp_util.c | 5 ++++-
 src/rxkad/ticket5.c       | 2 +-
 tests/common/rxkad.c      | 5 ++++-
 7 files changed, 16 insertions(+), 6 deletions(-)

-- 
OpenAFS Master Repository