OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-569-g21491d9

Gerrit Code Review gerrit@openafs.org
Thu, 7 Nov 2024 16:35:31 -0500


The following commit has been merged in the master branch:
commit 21491d9a822433c42b031b173bf0015a3122d084
Author: Mark Vitale <mvitale@sinenomine.net>
Date:   Mon Nov 4 12:39:32 2024 -0500

    Restore max() macro for Heimdal
    
    Commit de46edef693d (Remove lowercase min/max macro definitions)
    inadvertently removed a definition of max() that is required by
    _krb5_n_fold() (src/external/heimdal/krb5/n-fold.c) if no system
    definition of max() is available.  For example, on Solaris this results
    in a kernel module with an undefined external symbol 'max', which
    prevents the kernel module from loading:
    
      genunix: [ID 819705 kern.notice] /kernel/drv/amd64/afs: undefined symbol
      genunix: [ID 826211 kern.notice]  'max'
      genunix: [ID 472681 kern.notice] WARNING: mod_load: cannot load module 'afs'
    
    Restore the required max() macro definition.
    
    Change-Id: I6bca2bb2b90d7cdbe90a3b769997cdc153f59f6c
    Reviewed-on: https://gerrit.openafs.org/15874
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>

 src/crypto/rfc3961/krb5_locl.h | 4 ++++
 1 file changed, 4 insertions(+)

-- 
OpenAFS Master Repository