OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-550-g1073e94

[Gerrit Code Review]

The following commit has been merged in the master branch:
commit 1073e9477950a5b73ec60226c91a0f1ba1e3e493
Author: Mark Vitale <mvitale@sinenomine.net>
Date:   Wed Sep 9 17:22:44 2020 -0400

    volser: remove check for VL_ENTDELETED
    
    Since the original IBM code import, UV_RestoreVolume2 (originally
    UV_RestoreVolume) has checked for VL_ENTDELETED from VLDB_GetEntryByID.
    However, if VL_ENTDELETED is received, we will act like we retrieved the
    vlentry successfully. If the -verbose flag is given, we'll try to print
    the entry (even though one was not returned), and we'll call VL_SetLock
    for the volume, which will almost certainly also fail with VL_ENTDELETED
    and bail out.
    
    Furthermore (also since the original IBM import), there is no longer any
    code path to set the volume entry flag VLDELETED. So it should be rare
    for any VL_* RPC to return VL_ENTDELETED; that would require an entry to
    have the VLDELETED flag carried over from a very old database.
    
    Therefore, it is safe and reasonable to simply remove the check for
    VL_ENTDELETED from UV_RestoreVolume2.  If we do somehow receive the
    VL_ENTDELETED error code, vos will terminate with an error instead of
    possibly printing an uninitialized entry.
    
    In addition, remove the same check for VL_ENTDELETED in the equivalent
    code path in libadmin's UV_RestoreVolume.
    
    Change-Id: I11d1c3306f67d68de54780f6aac75e4c27779db4
    Reviewed-on: https://gerrit.openafs.org/14357
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: Andrew Deason <adeason@sinenomine.net>

 src/libadmin/vos/vsprocs.c | 2 +-
 src/volser/vsprocs.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
OpenAFS Master Repository