OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_13_2-39-gfe009bb

[Gerrit Code Review]

The following commit has been merged in the openafs-stable-1_8_x branch:
commit fe009bb0537c80074b4a56ce871e9043216baf32
Author: Mark Vitale <mvitale@sinenomine.net>
Date:   Mon Aug 10 13:28:19 2020 -0400

    viced: Ignore on-disk fsstate HashTable data
    
    Currently, if the fileserver tries to restore fsstate.dat and the
    included FE hashtable does not match our in-memory size (FEHASH_SIZE),
    we'll discard the entire state file. This is unnecessary, since we
    could just add the FEs to our hashtable ourselves; the on-disk
    hashtable data is not required.
    
    Furthermore, loading the hashtable from disk isn't even terribly
    efficient when the hashtable sizes do match, since any indices need to
    be converted from the on-disk values to in-memory values
    (fe_OldToNew). So if we're processing the FE hashtable indices anyway,
    we might as well just add them to the hashtable like normal, and
    ignore the values on disk.
    
    So, ignore loading the "fehash" data from the fsstate file, and just
    add file entries to our hashtable as we read them in. This ends up
    being slightly faster, simpler, and more flexible, since we don't need
    to worry about reflecting any changes to our hashtable in the
    fsstate.dat file.
    
    At least for now, we still write our hashtable data to fsstate.dat, in
    case other utilities (or older fileservers) need it.
    
    [adeason@sinenomine.net: Converted to always ignore on-disk hashtable
    data.]
    
    Reviewed-on: https://gerrit.openafs.org/14738
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    (cherry picked from commit f3629f87daa0c9067fbeb66d48ba1deb6fafac06)
    
    Change-Id: Icea91fe2ea266ae9fb53beb12dd7b664a4b30cb9
    Reviewed-on: https://gerrit.openafs.org/16022
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/viced/callback.c | 89 +++++++++++++---------------------------------------
 1 file changed, 21 insertions(+), 68 deletions(-)

-- 
OpenAFS Master Repository