OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-398-gaaa63f1

Gerrit Code Review gerrit@openafs.org
Fri, 5 Dec 2025 11:13:50 -0500


The following commit has been merged in the master branch:
commit aaa63f174e2774e72c343a62a0c799e8b056ff90
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Thu Dec 4 11:34:53 2025 -0500

    pts: Call pr_End() before pr_Initialize2()
    
    Currently, GetGlobals() calls CleanUp() before calling pr_Initialize2(),
    to make sure any existing ubik client is destroyed (by calling pr_End())
    before creating a new one.
    
    But after CleanUp() calls pr_End(), it also calls rx_Finalize() to
    teardown the entire rx stack. This is completely unnecessary; rx can
    stay initialized when we call pr_Initialize2() again, and we'll just
    create a new ubik client with new rx connections.
    
    Change GetGlobals() to call pr_End() before pr_Initialize2(), instead of
    the full CleanUp() function. This more accurately mirrors the previous
    pr_Initialize2() call, and doesn't do any extra unnecessary teardown.
    
    This change means if the security context changes, we will create a new
    ubik client, but rx will already be initialized when pr_Initialize2() is
    called again. And so the call to rx_Init() inside pr_Initialize2() will
    return immediately.
    
    Change-Id: Ib36444937b6c5272d6fb0ad0429595e85ee8a517
    Reviewed-on: https://gerrit.openafs.org/16644
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>

 src/ptserver/pts.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
OpenAFS Master Repository