OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-145-g7cd1d64

[Gerrit Code Review]

The following commit has been merged in the master branch:
commit 7cd1d64ec21a47fe9ba4e04104bb091b706e7356
Author: Mark Vitale <mvitale@sinenomine.net>
Date:   Tue May 14 15:06:31 2024 -0400

    rx: Update lock order and coverage comments
    
    Document the lock order and lock coverage for rx_mallocedPktQ_lock.
    Improve the list of global variables and structures covered by
    rx_freePktQ_lock.
    
    One user of rxi_NeedMorePackets currently violates the rules we are
    documenting in this commit: in rx_CheckPackets(), we examine
    rxi_NeedMorePackets outside of rx_freePktQ_lock. This may be a problem,
    but simply locking rx_freePktQ_lock here wouldn't really fix anything,
    since rx_freePktQ_lock would be unlocked immediately afterwards,
    allowing the value to change immediately after we checked it. Addressing
    this problem is outside the scope of this commit; just mention the
    possible issue in comments for now.
    
    rx_CheckPackets() has done this since before OpenAFS 1.0, but in OpenAFS
    1.0, rx_CheckPackets() was only called during startup (rx_Init) and in a
    periodic background thread (afs_Daemon); commit 54bf41004b (rx: work
    harder to notice and handle MorePackets request), included in OpenAFS
    1.6.0, added calls in the listener. So if we incorrectly do nothing in
    rx_CheckPackets() in the listener, our behavior here is only as bad as
    it was before OpenAFS 1.6.0.
    
    rxi_ReceiveDebugPacket() also intentionally violates some locking rules;
    add a comment to explicitly mention that.
    
    No functional change is incurred by this commit - it is just
    documentation.
    
    [adeason@sinenomine.net: Add comments in rx_CheckPackets(),
    rxi_ReceiveDebugPacket().]
    
    Change-Id: I4e9e9f97555f80fa525226ace27e260317681027
    Reviewed-on: https://gerrit.openafs.org/15888
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>

 src/rx/rx.c        |  9 +++++++++
 src/rx/rx_packet.c | 21 +++++++++++++++++++--
 2 files changed, 28 insertions(+), 2 deletions(-)

-- 
OpenAFS Master Repository