OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_13_2-78-g82063bd

[Gerrit Code Review]

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 82063bde8f61fc0a997fe88ec64bbfc26fbdb97c
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Fri Aug 2 21:55:55 2024 -0500

    packaging: Check for nonzero $? for command failure
    
    In a few perl scripts (that happen to be for macOS), we check whether
    '$? >> 8' is zero to see whether a command failed. But the value of
    '$? >> 8' is just the exit code of the process. If it instead, for
    example, was killed by a signal, there is no exit code, and '$? >> 8'
    may not be accurate (the terminating signal is in '$? & 127'). We should
    check if $? is nonzero at all to see if an error happened.
    
    To avoid any possible issues, update all of our checks for command
    failure to check if $? is nonzero, instead of '$? >> 8'. In notarize.pl,
    print out the whole status in addition to the exit code, just to be
    clear in case the command somehow terminates from a signal.
    
    Reviewed-on: https://gerrit.openafs.org/15980
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    (cherry picked from commit 9ef6aac17a7fca5bd1ca6b77459f3d7b48bbf018)
    
    Change-Id: I481131f2ab0ff0cfc82e6452facfd8b508a4e56c
    Reviewed-on: https://gerrit.openafs.org/16078
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/packaging/MacOS/Uninstall       |  3 +--
 src/packaging/MacOS/Uninstall.14.15 |  3 +--
 src/packaging/MacOS/notarize.pl     | 20 +++++++++-----------
 3 files changed, 11 insertions(+), 15 deletions(-)

-- 
OpenAFS Master Repository