OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-284-gfab6a02
Gerrit Code Review
gerrit@openafs.org
Tue, 29 Jul 2025 15:57:02 -0400
The following commit has been merged in the master branch:
commit fab6a024a0d290e4a8d4a2d75e382046d543e24a
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Jul 25 23:13:27 2025 -0500
rx: Remove afs_cv_timedwait, most CV_TIMEDWAIT
Currently, there is only one caller of the macro CV_TIMEDWAIT(), which
is in pthread-only code and was added in commit 3394644531
(rx-afs-kmutex-kcondvar-20090113). There was another pthread-only caller
added in commit 34767c6a0f (down with assert, up with osi_Assert), but
was later removed in commit f5a643ad6d (Add opr/lock.h and tidy locking
macros).
The related function afs_cv_timedwait() also has never had any callers
at all (besides CV_TIMEDWAIT()) ever since it was introduced in commit
7b8d569f42 (First pass at better signal handling:).
Despite this, CV_TIMEDWAIT() and afs_cv_timedwait() have KERNEL
definitions for various platforms, some of which are somewhat complex,
which have existed (but never used) since before OpenAFS 1.0.
Remove these macros and functions, except for the pthread-only
CV_TIMEDWAIT(), which is still in use.
Note that similar functionality exists in other libafs-only functions
(afs_osi_Wait, afs_osi_TimedSleep), but the API is very different.
Change-Id: I94c9686896214e4268629dc76bcbf06b6857edc3
Reviewed-on: https://gerrit.openafs.org/16489
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
src/rx/AIX/rx_kmutex.h | 28 ----------------------------
src/rx/DARWIN/rx_kmutex.h | 25 -------------------------
src/rx/FBSD/rx_kmutex.h | 6 ------
src/rx/IRIX/rx_kmutex.h | 29 -----------------------------
src/rx/LINUX/rx_kmutex.c | 36 +-----------------------------------
src/rx/LINUX/rx_kmutex.h | 1 -
src/rx/NBSD/rx_kmutex.c | 22 ----------------------
src/rx/NBSD/rx_kmutex.h | 14 --------------
src/rx/SOLARIS/rx_kmutex.c | 34 ----------------------------------
src/rx/SOLARIS/rx_kmutex.h | 9 ---------
src/rx/UKERNEL/rx_kmutex.h | 1 -
src/rx/rx_lwp.h | 1 -
src/rx/rx_prototypes.h | 2 --
13 files changed, 1 insertion(+), 207 deletions(-)
--
OpenAFS Master Repository