OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_13_2-29-gae8b53f
Gerrit Code Review
gerrit@openafs.org
Thu, 27 Mar 2025 12:14:20 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit ae8b53feda27cf5daa0d79d425ed56f3f707a176
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Jan 3 11:48:10 2025 -0700
Avoid rxi_tracename overflow
When processing the -trace option for the vlserver (and a couple of
other places), we can easily overflow the rxi_tracename array if the
given string is too big. While the way this global setting works in
general isn't the best, at least for now just prevent the buffer
overflow by doing a simple bounds check with strlcpy.
Reviewed-on: https://gerrit.openafs.org/14753
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
(cherry picked from commit a794383f5e035231797a3683ae67dbf9e9d7bcd3)
Conflicts:
src/rx/test/testserver.c - added the "extern char rxi_tracename"
from the master commit:
"rx: Cleanup and build src/rx/test" (236cb51b833d)
Change-Id: I456a1db092f5180c11f4a6f5ad872e11799a1103
Reviewed-on: https://gerrit.openafs.org/16010
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/rx/rx_trace.c | 6 +++++-
src/rx/test/testserver.c | 11 +++++++++--
src/rxkad/test/stress.c | 9 +++++++--
src/vlserver/vlserver.c | 6 +++++-
4 files changed, 26 insertions(+), 6 deletions(-)
--
OpenAFS Master Repository