OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_13_2-46-g8de21fd

[Gerrit Code Review]

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 8de21fd7614f43ba0a45d1ff25b2411102db2ac8
Author: Cheyenne Wills <cwills@sinenomine.net>
Date:   Wed Apr 7 10:51:58 2021 -0600

    cf: Run AFS_LT_INIT after setting CC
    
    Since libtool support was introduced for 1.8.x in commit 69f26ece (Add
    libtool support), we've run LT_INIT or AFS_LT_INIT early on in
    configure.ac.
    
    If CC isn't set, AFS_LT_INIT defaults to using gcc when it's available.
    On Solaris, we set CC and CFLAGS ourselves later (in osconf.m4) to use
    the Solaris Studio compiler, but this doesn't change the compiler that
    AFS_LT_INIT already chose. As a result, on Solaris if no value for CC is
    given during configure and gcc is available, some libtool commands will
    try to use gcc with CFLAGS intended for the Solaris Studio compiler,
    which will fail.
    
      /bin/sh ../../libtool --quiet --mode=link --tag=CC ... -mt ...
      gcc: error: unrecognized command line option '-mt'; did you mean '-t'?
    
    To fix this, move AFS_LT_INIT into osconf.m4 after our platform-specific
    macros have had a chance to set CC. Also move our checks for AR, AS,
    etc. to after AFS_LT_INIT, since AFS_LT_INIT sets those.
    
    Note.  Without GCC installed on a Solaris system, libtool will find the
    Solaris Studio compiler (assuming that PATH is set up correctly) and the
    build will proceed successfully. Just installing the GCC package is
    sufficient to break the build.
    
    This commit fixes a regression from 1.6.x where having the GCC package
    installed on the system would not break the build.
    
    Reviewed-on: https://gerrit.openafs.org/14585
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 0a58d21881d7e91deccb416e8d2c272e14b412dd)
    
    Change-Id: I6a961a3a5586c6c68ddfc90a758af16b3b45adb8
    Reviewed-on: https://gerrit.openafs.org/16097
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 configure.ac     |  2 --
 src/cf/osconf.m4 | 26 ++++++++++++++------------
 2 files changed, 14 insertions(+), 14 deletions(-)

-- 
OpenAFS Master Repository