OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-326-gd308764
Gerrit Code Review
gerrit@openafs.org
Mon, 20 Oct 2025 16:19:08 -0400
The following commit has been merged in the master branch:
commit d3087641058a8fe982a7280401f07f7c2ce72499
Author: Koustubh Mattikalli <koustubh.mattikalli@ibm.com>
Date: Fri Aug 29 16:37:49 2025 +0530
log: Keep rxgk tokens for unlog -cell
The current implementation of unlog removes all rxgk tokens
regardless of the "-cell" option provided, leading to unintended
token deletions. This happens because "unlog -cell" currently works by
discarding all tokens and then re-adding all tokens that don't match the
given -cell. But it is using the old ktc_GetToken() interface, which
only works for rxkad tokens, so any non-rxkad tokens (including rxgk
tokens) get discarded, regardless of cell.
To fix this, replace calls to ktc_ListTokens(), ktc_GetToken(), and
ktc_SetToken() with their newer counterparts ktc_ListTokensEx(),
ktc_GetTokenEx(), and ktc_SetTokenEx(), which work with all tokens.
Change struct tokenInfo to use a struct ktc_setTokenData for use with
these new functions, instead of the old struct ktc_token/ktc_principal
fields.
Also change unlog_CheckUnlogList() to take a cell name directly, instead
of a ktc_principal, since we no longer have a struct ktc_principal to
give it.
Co-authored-by: Kailas Zadbuke <kailashsz@in.ibm.com>
Co-authored-by: Amar Bhandari <amar.bhandari@ibm.com>
Change-Id: I37c8a469704287acb2b995e9c08069fd9f30f627
Reviewed-on: https://gerrit.openafs.org/16531
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
src/log/unlog.c | 41 ++++++++++++++++++++---------------------
1 file changed, 20 insertions(+), 21 deletions(-)
--
OpenAFS Master Repository