OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-351-g67b0109

Gerrit Code Review gerrit@openafs.org
Tue, 28 Oct 2025 19:07:46 -0400


The following commit has been merged in the master branch:
commit 67b01091e11c3dbe55fee52fae275bedb8914185
Author: Mark Vitale <mvitale@sinenomine.net>
Date:   Thu Aug 28 21:09:07 2025 -0400

    DARWIN: Ensure 'make packages' fails if codesign fails
    
    Although pkgbuild.sh has 'set -e' in force, the following 'find' command
    does not stop the build if 'codesign' fails for any reason:
    
        find "$PKGROOT" -type f -exec codesign --verbose --force \
               --timestamp --sign "$APP_KEY" $CODESIGN_OPTS {} \;
    
    This is normal documented behavior for 'find'; failed predicates do not
    influence the return code of 'find' itself.
    
    Modify the logic in pkgbuild.sh.in to ensure the build will stop if
    codesign fails for any file.
    
    Discovered during a network outage when codesign failed with:
      'The timestamp service is not available.'
    
    While here, clarify the comment for the other codesign stanza.
    
    Change-Id: If46cb04eed6d091dc3ac9f3ca7b6b17d446b041e
    Reviewed-on: https://gerrit.openafs.org/16532
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>

 src/packaging/MacOS/pkgbuild.sh.in | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

-- 
OpenAFS Master Repository