OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-460-g62dd28e

Gerrit Code Review gerrit@openafs.org
Fri, 24 Apr 2026 10:09:42 -0400


The following commit has been merged in the master branch:
commit 62dd28e497e77e3863118e02e5cf1196b6eddf9d
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Thu Apr 23 09:45:01 2026 -0500

    afs: Don't log EINTR errors for dying pid on Linux
    
    Since commit 1a672914ab (afs: Do not always ignore errors in
    afs_GetDSlot), we log a message like this if we encounter an error
    reading from the disk cache (later commits added some more info in the
    message):
    
        afs: disk cache read error in CacheItems slot 123 off 456/789 code -4/80 pid 123 (procname)
    
    At the time, these errors were important to record, since before that
    commit, they could cause panics and cache corruption. In the years since
    then, though, by far the most common situation where these messages are
    seen on Linux are harmless: we can see an EINTR error if our process has
    a pending fatal signal, and will be killed as soon as we return to
    userspace.
    
    Since this specific situation is known, skip these log messages for that
    case, so users are not scared by scary-sounding messages. This also
    makes it much easier to see if there are real I/O errors when
    interacting with the cache, which is a much more important case worthy
    of logging.
    
    Do the same thing for a couple of messages in afs_UFSGetVolSlot() when
    interacting with the VolumeInfo file, since those messages can occur for
    the same reason.
    
    To consolidate the relevant logic, introduce the function
    afs_ShouldLogCacheError().
    
    Change-Id: I827b75078b5958c800be1144eff7f3be4191ca1a
    Reviewed-on: https://gerrit.openafs.org/16774
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>

 src/afs/afs_dcache.c     | 21 +++++++++++++++++++++
 src/afs/afs_prototypes.h |  1 +
 src/afs/afs_volume.c     | 12 ++++++++----
 3 files changed, 30 insertions(+), 4 deletions(-)

-- 
OpenAFS Master Repository